fix(react): the unevaluated-expression diagnostic lists properties, the channel its sibling recommends - #7955

Fixes #7849

What was wrong

Two dev-build diagnostics in @object-ui/react answered the same authoring
question two ways, and one node can trip both:

• utils/propsBagDiagnostic.ts — "props is NOT hoisted onto the node — only
  properties.* is. … Write them under properties instead (or at node level,
  where the node's schema declares the key)."
• utils/unevaluatedExpression.ts — "Channels that do evaluate and read back
  today: content, or resolve the value in the host before handing the schema
  to SchemaRenderer."

An author whose node tripped both was told to use properties by the first and,
by the second, that the only channels that work are content or host-side
resolution.

Note the card pointed at packages/react/src/SchemaRenderer.tsx; the two
messages actually live in the two utils/ modules above.

Direction: measured, not inferred from the COMPAT label

The card left two readings open — the enumeration is incomplete, or properties
is a shim on the way out and the recommendation is the bug. Deciding that from
the word COMPAT on the hoist would be an inference, so it was measured
instead. No retirement is on record for properties:

⇒ the enumeration was the wrong half. This PR adds properties to it, and
changes nothing else.

Reproduction of the card's three readings

Re-run on this branch's base through the real renderers (packages/components/src/renderers/**)
driven by SchemaRenderer, rendered DOM:

badge, properties: { label: "${data.status}", variant: "${…}" }
  -> class "… border-transparent bg-secondary text-secondary-foreground …"
     and TEXT CONTENT "completed"                                    WORKS

card, properties: { className: "${data.isPriority ? 'border-red-500' : …}" }
  -> class "rounded-lg border bg-card text-card-foreground shadow-sm
     border-red-500"                                                 WORKS

badge, props: { … same keys … }
  -> "completed" lands only on a DOM ATTRIBUTE; TEXT CONTENT EMPTY   NOT READ BACK
card,  props: { … same keys … }
  -> class "rounded-lg border bg-card text-card-foreground shadow-sm"
     — border-red-500 ABSENT                                         NOT READ BACK

All three reproduce the card exactly, so both readings stood and the retirement
measurement is what picked the direction.

The fix

formatUnevaluatedExpressionMessage now reads:

Channels that do evaluate and read back today: content; properties.*,
which is evaluated and then HOISTED onto the node, so a renderer declared as
({ schema }) reads it back at the node top level; or resolve the value in the
host before handing the schema to SchemaRenderer.

The wording is borrowed from the sibling diagnostic on purpose ("hoisted onto
the node", "a renderer declared as ({ schema })") — one hoist, one vocabulary,
no invented terms.

The pin, and its positive control

packages/react/src/__tests__/diagnosticChannelConsistency.test.ts is a
derived assertion, not two hard-coded strings: the channel is parsed back
out of the message propsBagDiagnostic actually emits, the enumeration is
parsed out of the other, and the test asserts the first appears in the second.
Reword either message and the pin still asks the question that matters. Both
regexes are asserted to have matched before they are compared, so a silent miss
cannot pass as green.

Positive control — contradiction reinstated (properties.* dropped from the
enumeration), mutation confirmed on disk before the run
(removed_text_count=0, injected_text_count=1, blob 4a476fe1 → fa52deb7):

× the channel the props diagnostic RECOMMENDS is listed by the unevaluated diagnostic as one that works
  Test Files  1 failed (1)   Tests  1 failed | 4 passed (5)

AssertionError: objectui#7849: `propsBagDiagnostic` tells the author to write the key
under `properties`, but `unevaluatedExpression`'s list of channels that evaluate and
read back does not mention it. …

Exactly one test red, and it names itself. Restore proven by state, not by
exit code: git diff HEAD empty and the blob back to HEAD's
4a476fe1efb027d8cdb5e456ee78cc5139e3e865. The script carried an absolute-path
trap … EXIT INT TERM.

Verification — all at final commit 888ebec86, clean tree

Changeset grade was not reasoned about — check-changeset-presence.mjs was
run and its verdict followed: it demanded one and scored "minor at most, never
major"; a dev diagnostic an author reads does change in a published package, so
patch.

Scope

• Clause-②: no
• Diagnostic text only. No evaluation, hoist or schema behaviour changed;
  the properties runtime is untouched.
• No content/docs/ page touched (the card's zero-properties-examples
  constraint holds), no packages/types/, no governance surface.
• File surface: the diagnostic source + one pin test (+ the changeset the
  checker demanded).

🤖 Generated with Claude Code

Generated by Claude Code